dant3 commented on code in PR #7422:
URL: https://github.com/apache/ignite-3/pull/7422#discussion_r2834614654
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java:
##########
@@ -208,6 +218,10 @@ public <V> V runConsistently(WriteClosure<V> closure)
throws StorageException {
locker0.unlockAll();
checkpointTimeoutLock.checkpointReadUnlock();
+
+ long duration = System.nanoTime() - startTime;
+ consistencyMetrics.recordRunConsistentlyDuration(duration);
+ consistencyMetrics.decrementActiveCount();
Review Comment:
The way our metrics framework is designed right now, we pay the toll always,
whenever it's enabled or disabled. Specific metric doesn't know if it's enabled
or disabled. To change that the whole metrics framework has to be changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
