dant3 commented on code in PR #7422:
URL: https://github.com/apache/ignite-3/pull/7422#discussion_r2845682448
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java:
##########
@@ -208,6 +218,10 @@ public <V> V runConsistently(WriteClosure<V> closure)
throws StorageException {
locker0.unlockAll();
checkpointTimeoutLock.checkpointReadUnlock();
+
+ long duration = System.nanoTime() - startTime;
+ consistencyMetrics.recordRunConsistentlyDuration(duration);
+ consistencyMetrics.decrementActiveCount();
Review Comment:
Thanks, I see. This is IMO a smell of the bad design of the metrics
framework that you can't use indivitual metrics without relying on the
metricSource kicking around, but sure, we can use that right now, as a poor man
solution. Anyways, I'll make sure its also enabled by default and add the
benchmarks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
