rpuch commented on code in PR #7422:
URL: https://github.com/apache/ignite-3/pull/7422#discussion_r2844879090
##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/PersistentPageMemoryMvPartitionStorage.java:
##########
@@ -208,6 +218,10 @@ public <V> V runConsistently(WriteClosure<V> closure)
throws StorageException {
locker0.unlockAll();
checkpointTimeoutLock.checkpointReadUnlock();
+
+ long duration = System.nanoTime() - startTime;
+ consistencyMetrics.recordRunConsistentlyDuration(duration);
+ consistencyMetrics.decrementActiveCount();
Review Comment:
Could we just do the `metricSource.enabled()` before computing durations and
doing increments? Or we could use polymorphism for our advantage. A virtual
call seems to be better than a non-virtual CAS.
Anyway, I consulted @ibessonov and he wants this metric source to always be
enabled. In this case, we need to benchmark the branch hard before merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
