anton-vinogradov commented on code in PR #13095: URL: https://github.com/apache/ignite/pull/13095#discussion_r3552042186
########## modules/core/src/main/java/org/apache/ignite/plugin/extensions/communication/CacheIdAware.java: ########## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.plugin.extensions.communication; + +/** Implemented by messages that carry a cache ID identifying the target cache. */ Review Comment: Done — the javadoc now states the purpose: the cache ID lets the generated marshaller and deployer resolve the cache object context used to (un)marshal and deploy the message's cache objects. ########## modules/codegen/src/main/java/org/apache/ignite/internal/NioField.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** + * Marks a {@code Message}-typed {@link Order} field that is unmarshalled early — on the NIO (read) thread — Review Comment: Reworded to be plainer and dropped the internal method name — now: "Marks an `@Order` field, of `Message` type, that is read on the network (NIO) thread rather than a worker thread. This is for routing headers such as the topic, which must be known before the message can be dispatched to a pool." ########## modules/commons/src/main/java/org/apache/ignite/plugin/extensions/communication/Message.java: ########## @@ -24,6 +24,21 @@ /** * Base class for all communication messages. + * <p> Review Comment: Fixed — now "Base type for all messages sent between nodes, both over the communication SPI and via discovery." ########## modules/commons/src/main/java/org/apache/ignite/plugin/extensions/communication/Message.java: ########## @@ -24,6 +24,21 @@ /** * Base class for all communication messages. + * <p> + * Wire fields are declared by annotating instance fields; {@link org.apache.ignite.internal.MessageProcessor} then Review Comment: Removed `wire` throughout — replaced with "serialized" (serialized fields / serialized form) in `Message` and the `@Marshalled*` annotations. ########## modules/commons/src/main/java/org/apache/ignite/plugin/extensions/communication/Message.java: ########## @@ -32,19 +47,25 @@ public interface Message { /** Registry of message class to direct type mappings, populated during factory initialization. */ Map<Class<?>, Short> REGISTRATIONS = new ConcurrentHashMap<>(); + /** Per-class cache over {@link #REGISTRATIONS}; keeps {@link #directType()} off the hash lookup on the hot path. */ Review Comment: Clarified — now "…keeps `directType()` off the map lookup done for every sent message." ########## modules/codegen/src/main/java/org/apache/ignite/internal/MarshalledCollection.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** Marks a {@code Collection} field whose wire form is a companion {@code @Order} array field named by {@link #value()}. */ Review Comment: Aligned with `@Marshalled`'s wording and added `@see Order`; also dropped `wire` here and in `@MarshalledMap`/`@MarshalledObjects`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
