anton-vinogradov commented on code in PR #13095: URL: https://github.com/apache/ignite/pull/13095#discussion_r3559386159
########## modules/codegen/src/main/java/org/apache/ignite/internal/NioField.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal; + +import java.lang.annotation.ElementType; +import java.lang.annotation.Retention; +import java.lang.annotation.RetentionPolicy; +import java.lang.annotation.Target; + +/** + * Marks a {@code Message}-typed {@link Order} field that is unmarshalled early — on the NIO (read) thread — + * instead of being deferred to the worker thread with the rest of the message. Used for routing headers such as + * the topic, which must be read before the message can be dispatched to a pool. + */ +@Retention(RetentionPolicy.CLASS) +@Target(ElementType.FIELD) +public @interface NioField { Review Comment: It can't — only the communication SPI's receive path (GridNioServer) invokes the generated `unmarshalNio`; discovery and other socket-based paths go through the full `MessageMarshaller.unmarshal`. So the name matches the mechanism exactly: the field is read on the NIO thread of the communication layer. A transport-neutral name would only make sense if a non-NIO transport ever fed this path, and none does — renaming now would also drag `unmarshalNio` through the generator and `MessageMarshaller` for no behavioural gain. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
