anton-vinogradov commented on code in PR #13095: URL: https://github.com/apache/ignite/pull/13095#discussion_r3559399496
########## modules/core/src/main/java/org/apache/ignite/plugin/extensions/communication/NonMarshallableMessage.java: ########## @@ -0,0 +1,22 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.plugin.extensions.communication; + +/** Marker interface: no {@link MessageMarshaller} is generated for implementing classes. */ +public interface NonMarshallableMessage extends Message { Review Comment: An annotation can't give us two things this marker relies on: (1) `NonMarshallableMessage extends Message`, so the compiler itself guarantees the marker is only placed on messages — with an annotation we'd need another processor validation for that; (2) interface inheritance is exactly the semantic we need — the generator skips marshal recursion for a field of type `X` because *any* subtype of `X` is also non-marshallable, which plain annotations don't provide (`@Inherited` is subtle both at runtime and in annotation processing). Plus the runtime side (`isAssignableFrom` at registration, `instanceof` in the factory guarantees) stays trivial, and it follows the codebase convention for message markers (`GridCacheDeployable`, `IgniteTxStateAware`, …). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
