anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3559828602
##########
modules/core/src/test/resources/codegen/ChildMessageSerializer.java:
##########
@@ -29,6 +29,10 @@
* @see org.apache.ignite.internal.MessageProcessor
*/
public class ChildMessageSerializer implements MessageSerializer<ChildMessage>
{
+ /** */
+ public ChildMessageSerializer() {
Review Comment:
Right, we don't — master generates serializers without it, and instantiation
is a plain `new`, for which the implicit default constructor of a public class
is equally public. It slipped in when the marshaller generator was split out
(marshallers do need a constructor, but only those carrying a `Marshaller`
field). Removed the emission for serializers and for marshaller classes without
the field, and cleaned the goldens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
