anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3559981600
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cluster/ClusterProcessor.java:
##########
@@ -379,6 +380,13 @@ public void initDiagnosticListeners() throws
IgniteCheckedException {
if (msg instanceof IgniteDiagnosticRequest) {
IgniteDiagnosticRequest infoReq =
(IgniteDiagnosticRequest)msg;
+ try {
+ MessageMarshaller.unmarshal(ctx.messageFactory(),
infoReq, ctx, null, U.gridClassLoader());
Review Comment:
It is now — good catch, this was a leftover. The manual call predates the
generic `unmarshalPayload` pass in `GridIoManager` (which now unmarshals every
non-cache message on both the regular and ordered paths before the listener
runs; the `KeyCacheObject` context is resolved by the generated marshaller from
`cacheId`). Removed the manual call; verified with the diagnostic-messages test
under the unmarshal-once check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
