anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3559914000
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/service/ServiceSingleNodeDeploymentResult.java:
##########
@@ -76,8 +77,14 @@ public Collection<Throwable> errors() {
* @param errors Exceptions.
*/
public void errors(@Nullable Collection<Throwable> errors) {
- if (!F.isEmpty(errors))
- this.errors = F.viewReadOnly(errors, ErrorMessage::new);
Review Comment:
Same story as in `IncrementalSnapshotVerifyResult` (one fix, three files):
`viewReadOnly` is a lazy view creating fresh `ErrorMessage`s per iteration, so
the marshal pass's per-element state was lost by the time `writeTo` iterated
again. Now unified to the eager `F.transform` one-liner, and the original
`!F.isEmpty` guard is restored (the loop version had drifted to `== null`). The
getter keeps its lazy view — that direction never feeds serialization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
