anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579804146
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/job/GridJobProcessor.java:
##########
@@ -1250,7 +1250,7 @@ public void processJobExecuteRequest(ClusterNode node,
final GridJobExecuteReque
try {
if (!loc)
- req.finishUnmarshal(marsh,
U.resolveClassLoader(dep.classLoader(), ctx.config()));
+ req.unmarshal(marsh,
U.resolveClassLoader(dep.classLoader(), ctx.config()));
Review Comment:
Not duplicated — master's own manual call, only renamed (`finishUnmarshal` →
`unmarshal`). `GridJobExecuteRequest` is `ExecutorAwareMessage`, not a
`MarshallableMessage` — there's no generated marshaller for it (only a
serializer), so this explicit call is the sole unmarshal, exactly as on master.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java:
##########
@@ -1039,7 +1039,7 @@ private GridFutureAdapter<Boolean> startCas(String key,
@Nullable Serializable e
DistributedMetaStorageCasMessage msg = new
DistributedMetaStorageCasMessage(reqId, key, expVal, newVal);
- msg.prepareMarshal(marshaller);
+ msg.marshal(marshaller);
Review Comment:
Not duplicated — `DistributedMetaStorageUpdateMessage`/`CasMessage` are
`DiscoveryCustomMessage`s, not `MarshallableMessage`s (no generated marshaller
exists for them), so this manual `marshal(marshaller)` is the only one — master
called `prepareMarshal` at the very same spot. It's also self-guarded (`val !=
null && valBytes == null`), so idempotent regardless.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/metastorage/persistence/DistributedMetaStorageImpl.java:
##########
@@ -1281,7 +1281,7 @@ private void completeCas(
Serializable oldVal = bridge.read(msg.key());
- msg.finishUnmarshal(marshaller);
+ msg.unmarshal(marshaller);
Review Comment:
Same — the manual `unmarshal` is the only one (no generated marshaller),
master's own call renamed; guarded by `expValBytes != null && expVal == null`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
