shishkovilja commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579049148


##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/CacheMetricsCacheSizeTest.java:
##########
@@ -106,8 +106,6 @@ public void testCacheSize() throws Exception {
         msg.addServerCacheMetrics(srvrId, cacheMetrics);
 
         MessageFactory msgFactory = 
((TcpDiscoverySpi)grid(0).context().discovery().getInjectedDiscoverySpi()).messageFactory();
-        MessageSerializer msgSerializer = 
msgFactory.serializer(msg.directType());

Review Comment:
   Missing empty line here.



##########
modules/core/src/test/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImplSelfTest.java:
##########
@@ -713,6 +715,14 @@ private static class StaleTopologyCommunicationSpi extends 
TcpCommunicationSpi {
                             ioMsg.skipOnTimeout()
                         );
 
+                        try {
+                            
MessageMarshaller.marshal(((IgniteEx)ignite).context().messageFactory(),

Review Comment:
   Why we need this change? What was broken in `GridIoManager`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to