anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3579840917
##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteKernal.java:
##########
@@ -1319,7 +1320,8 @@ else if (e instanceof IgniteCheckedException)
}
/** */
- private void initMessageFactory() throws IgniteCheckedException {
+ @TestOnly
Review Comment:
Right — the annotation was factually wrong: `initMessageFactory()` runs in
production too (`start()` calls it); it's `public` only for the cross-package
`GridCacheIoManagerRetryTest`. Dropped `@TestOnly` and documented the
visibility instead.
##########
modules/core/src/main/java/org/apache/ignite/internal/processors/task/GridTaskWorker.java:
##########
@@ -1416,7 +1416,7 @@ private void sendRequest(ComputeJobResult res) {
if (loc)
ctx.job().processJobExecuteRequest(ctx.discovery().localNode(), req);
else {
- req.prepareMarshal(marsh);
+ req.marshal(marsh);
Review Comment:
It's master's manual call, renamed (`prepareMarshal` → `marshal`);
`GridJobExecuteRequest` has no generated marshaller, so this isn't a
`MarshallableMessage` override. The naming overlap is real, but it's the same
hook-rename topic as the `GridDhtPartitionsFullMessage`/`GridCacheEntryInfo`
threads — better as one separate PR than diverging this single call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
