anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3589076624
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteIoTestMessage.java:
##########
@@ -240,10 +238,7 @@ public long responseReceivedTsMillis() {
return resRcvTsMillis;
}
- /**
- * This method is called to initialize tracing variables.
- * TODO: introduce direct message lifecycle API?
- */
+ /** Captures the received timestamp; repeated calls are no-ops. */
Review Comment:
Fixed — "Captures the received timestamp at the first call; later calls are
no-ops."
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteIoTestMessage.java:
##########
@@ -258,10 +253,7 @@ public void onAfterRead() {
}
}
- /**
- * This method is called to initialize tracing variables.
- * TODO: introduce direct message lifecycle API?
- */
+ /** Captures the sent timestamp; repeated calls are no-ops. */
Review Comment:
Fixed — "Captures the sending timestamp at the first call; later calls are
no-ops."
##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/DiscoveryUnmarshalVulnerabilityTest.java:
##########
@@ -81,11 +93,14 @@ public class DiscoveryUnmarshalVulnerabilityTest extends
GridCommonAbstractTest
/** {@inheritDoc} */
@Override protected IgniteConfiguration getConfiguration(String
igniteInstanceName) throws Exception {
MessageFactoryProvider msgFactoryProvider = new
AbstractMarshallableMessageFactoryProvider() {
- @Override public void registerAll(MessageFactory factory) {
+ @Override public void registerAll(IgniteMessageFactory factory) {
+ serializer = new MessageSerializerWrapper(this);
Review Comment:
Applied — the two wrappers are constructed inline in `register`, and the
`serializer`/`marshaller` fields are gone.
##########
modules/core/src/test/java/org/apache/ignite/spi/discovery/tcp/DiscoveryUnmarshalVulnerabilityTest.java:
##########
Review Comment:
Removed — the serializer wrapper's `provider` field was write-only (the
marshaller wrapper's is the one that's actually read, kept).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
