anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3589145675
##########
modules/nio/src/main/java/org/apache/ignite/plugin/extensions/communication/MessageSerializer.java:
##########
@@ -38,4 +38,36 @@ public interface MessageSerializer<M extends Message> {
* @return Whether message was fully read.
*/
public boolean readFrom(M msg, MessageReader reader);
+
+ /**
+ * Writes the message using the serializer resolved from the factory.
+ *
+ * @param factory Message factory.
+ * @param msg Message instance.
+ * @param writer Writer.
+ * @param <M> Message type.
+ * @return Whether message was fully written.
+ */
+ static <M extends Message> boolean writeTo(MessageFactory factory, M msg,
MessageWriter writer) {
Review Comment:
Made it consistent — the two static entry points are `public` now, matching
the instance `writeTo`/`readFrom` above (the `private` `resolve` stays private).
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/ErrorMessage.java:
##########
Review Comment:
Agreed it's a generic error carrier, not communication-specific. It's
referenced from ~a dozen messages, so moving the package is a
mechanical-but-wide change; as you suggest, better as a separate subticket than
growing this PR. I'll file one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
