anton-vinogradov commented on code in PR #13095:
URL: https://github.com/apache/ignite/pull/13095#discussion_r3589234226
##########
modules/core/src/main/java/org/apache/ignite/internal/managers/communication/IgniteMessageFactoryImpl.java:
##########
@@ -42,6 +45,13 @@ public class IgniteMessageFactoryImpl implements
MessageFactory {
/** Message serializers. */
private final MessageSerializer[] msgSerializers =
(MessageSerializer[])Array.newInstance(MessageSerializer.class, ARR_SIZE);
+ /** Message marshallers (null entry = no marshaller registered for that
type). */
+ private final MessageMarshaller[] msgMarshallers =
(MessageMarshaller[])Array.newInstance(MessageMarshaller.class, ARR_SIZE);
Review Comment:
Applied your patch in this PR — `git apply` went in cleanly on top of the
current tree. `MessageFactory<T extends Message>` and `IgniteMessageFactory<M
extends Message, CM extends GridCacheMessage>` are parametrized, and the call
sites use `<? extends Message>` / `<Message, GridCacheMessage>`. It coexists
with the `MessageMarshalling` / `MessageSerializer` resolve dispatch. Verified
green: MessageProcessorTest goldens 34/34, MessageSerializationArchitectureTest
3/3, the factory tests (IgniteMessageFactoryImplTest,
MessageFactoryMarshallerInitializationTest, MessageDirectTypeIdConflictTest),
DirectByteBufferStreamImplByteOrderSelfTest 16/16, marshal/unmarshal-once, and
DiscoveryUnmarshalVulnerabilityTest 7/7; checkstyle clean across nio + core.
Thanks for preparing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
