maksaska commented on code in PR #13413:
URL: https://github.com/apache/ignite/pull/13413#discussion_r3957675862
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_aware.py:
##########
@@ -117,10 +117,27 @@ def start_node(self, node, **kwargs):
super().start_node(node, **kwargs)
- wait_until(lambda: self.alive(node), timeout_sec=10)
+ wait_until(lambda: self.alive(node), timeout_sec=10,
+ err_msg=lambda: self.__jvm_startup_failure_msg(node))
ignite_jmx_mixin(node, self)
+ def __jvm_startup_failure_msg(self, node):
+ """
+ A JVM that rejects an option (an unknown collector, a bad heap value,
two collectors selected)
+ dies before it logs anything Ignite-shaped, so without the console
tail this is a bare timeout.
+ """
+ console_log = os.path.join(self.log_dir, "console.log")
+
+ try:
+ tail = "".join(node.account.ssh_capture(f"tail -n 30
{console_log}", allow_fail=True))
+ except Exception as err: # pylint: disable=broad-except
+ # Never let diagnostics mask the timeout they are diagnosing.
+ tail = f"<unable to read {console_log}: {err}>"
Review Comment:
Agree. Simplified this part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
