maksaska commented on code in PR #13413:
URL: https://github.com/apache/ignite/pull/13413#discussion_r3957670246
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -342,17 +403,11 @@ class IgniteApplicationSpec(IgniteSpec):
"""
Spec to run ignite application
"""
- def __init__(self, service, jvm_opts=None, merge_with_default=True):
- super().__init__(
- service,
- merge_jvm_settings(self.__get_default_jvm_opts() if
merge_with_default else [],
- jvm_opts if jvm_opts else []),
- merge_with_default)
-
- def __get_default_jvm_opts(self):
+ def _service_defaults(self):
return [
"-DIGNITE_NO_SHUTDOWN_HOOK=true", # allows performing operations
on app termination.
"-Xmx1G",
+ "-Xms1G", # kept in step with -Xmx: _remove_duplicates drops the
base -Xmx but keeps the base -Xms.
Review Comment:
Agree. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
