maksaska commented on code in PR #13413:
URL: https://github.com/apache/ignite/pull/13413#discussion_r3957759220
##########
modules/ducktests/tests/ignitetest/services/utils/ignite_spec.py:
##########
@@ -91,14 +110,52 @@ def __init__(self, service, jvm_opts=None,
merge_with_default=True):
default options will be applied.
"""
self.service = service
- self.jvm_opts = merge_jvm_settings(self.__get_default_jvm_opts() if
merge_with_default else [],
- jvm_opts if jvm_opts else [])
+
+ # The caller's delta is kept alongside the merged result so that
another service can inherit the
+ # tuning a test applied here without inheriting this service's
role-dependent options too.
+ # See rebuild_as() -- copying the resolved list across services is
what broke the CDC path.
Review Comment:
Corrected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
