Arsnael commented on a change in pull request #358:
URL: https://github.com/apache/james-project/pull/358#discussion_r606957534
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/VacationResponseGetMethodContract.scala
##########
@@ -482,14 +482,16 @@ trait VacationResponseGetMethodContract {
.asString
.stripMargin
- assertThatJson(response).isEqualTo(
+ assertThatJson(response)
+ .whenIgnoringPaths("methodResponses[0][1].description")
Review comment:
It just feels pointless of having ignoring description and then a
description in the assert... Maybe better to drop the description field in the
assert json answer then, and having potentially a comment explaining quickly
why, if somebody wants to give it a shot later?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
