chibenwa commented on a change in pull request #358:
URL: https://github.com/apache/james-project/pull/358#discussion_r607581136
##########
File path:
server/protocols/jmap-rfc-8621/src/main/scala/org/apache/james/jmap/mail/MailboxSet.scala
##########
@@ -46,7 +47,7 @@ case class MailboxSetRequest(accountId: AccountId,
onDestroyRemoveEmails:
Option[RemoveEmailsOnDestroy]) extends WithAccountId
object MailboxSetRequest {
- type MailboxCreationId = String Refined NonEmpty
+ type MailboxCreationId = String Refined IdConstraint
Review comment:
But thanks for pointing out this good practice that was of our radar...
2 hours fighting with the code base is still acceptable, no significant
rework needed so I decided to give it a shot.
We might now have some "Id POJOs" that represents similar concepts and might
be de-duplicated - but I will keep that for other PRs / refactorings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
