chibenwa commented on a change in pull request #358:
URL: https://github.com/apache/james-project/pull/358#discussion_r607434478
##########
File path:
server/protocols/jmap-rfc-8621-integration-tests/jmap-rfc-8621-integration-tests-common/src/main/scala/org/apache/james/jmap/rfc8621/contract/MailboxSetMethodContract.scala
##########
@@ -1059,7 +1059,7 @@ trait MailboxSetMethodContract {
| "notCreated": {
| "C42": {
| "type": "invalidArguments",
- | "description": "'/parentId' property in mailbox object is
not valid: Predicate isEmpty() did not fail."
+ | "description": "'/parentId' property in mailbox object is
not valid: Left predicate of ((!(0 < 1) && !(0 > 255)) &&
\\"\\".matches(\\"^[#a-zA-Z0-9-_]*$$\\")) failed: Predicate taking size() = 0
failed: Left predicate of (!(0 < 1) && !(0 > 255)) failed: Predicate (0 < 1)
did not fail."
Review comment:
This is over-precise because this error is generated at the JSON
deserialization layer, and we likely have no to little context there.
Instead of relying on JSON refined implicit, then we would have to provide
separate types deserialization wrapping our knowledge, I imagine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
