chibenwa commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r657666634
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdDAO.java
##########
@@ -357,7 +358,14 @@ private PreparedStatement
prepareSelectUidRangeLimited(Session session) {
MessageUid.of(row.getLong(IMAP_UID))))
.flags(FlagsExtractor.getFlags(row))
.modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
-
.threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))
+ .threadId(getThreadIdFromRow(row))
.build());
}
+
+ private ThreadId getThreadIdFromRow(Row row) {
Review comment:
I would prefer the parameters to be `Row row, MessageId messageId` so
that we do not read the messageId twice...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
