chibenwa commented on a change in pull request #504:
URL: https://github.com/apache/james-project/pull/504#discussion_r657666961
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdToImapUidDAO.java
##########
@@ -253,10 +254,17 @@ private ComposedMessageIdWithMetaData
toComposedMessageIdWithMetadata(Row row) {
MessageUid.of(row.getLong(IMAP_UID))))
.flags(FlagsExtractor.getFlags(row))
.modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
-
.threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))
+ .threadId(getThreadIdFromRow(row))
.build();
}
+ private ThreadId getThreadIdFromRow(Row row) {
+ if (row.getUUID(THREAD_ID_LOWERCASE) == null) {
Review comment:
idem
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdDAO.java
##########
@@ -357,7 +358,14 @@ private PreparedStatement
prepareSelectUidRangeLimited(Session session) {
MessageUid.of(row.getLong(IMAP_UID))))
.flags(FlagsExtractor.getFlags(row))
.modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
-
.threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))
+ .threadId(getThreadIdFromRow(row))
.build());
}
+
+ private ThreadId getThreadIdFromRow(Row row) {
+ if (row.getUUID(THREAD_ID_LOWERCASE) == null) {
Review comment:
I'd like we do not read THREAD_ID_LOWERCASE twice
##########
File path:
mailbox/cassandra/src/main/java/org/apache/james/mailbox/cassandra/mail/CassandraMessageIdToImapUidDAO.java
##########
@@ -253,10 +254,17 @@ private ComposedMessageIdWithMetaData
toComposedMessageIdWithMetadata(Row row) {
MessageUid.of(row.getLong(IMAP_UID))))
.flags(FlagsExtractor.getFlags(row))
.modSeq(ModSeq.of(row.getLong(MOD_SEQ_LOWERCASE)))
-
.threadId(ThreadId.fromBaseMessageId(messageIdFactory.of(row.getUUID(THREAD_ID))))
+ .threadId(getThreadIdFromRow(row))
.build();
}
+ private ThreadId getThreadIdFromRow(Row row) {
Review comment:
idem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
