Arsnael commented on a change in pull request #546:
URL: https://github.com/apache/james-project/pull/546#discussion_r676276716
##########
File path:
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/BucketNameResolverTest.java
##########
@@ -50,10 +65,45 @@ void resolveShouldReturnValueWhenNamespace() {
assertThat(resolver.resolve(BucketName.of("namespace")))
.isEqualTo(BucketName.of("namespace"));
}
+
+ @Test
+ void unresolveShouldReturnPassedValue() {
+ BucketNameResolver resolver = BucketNameResolver.builder()
+ .noPrefix()
+ .namespace(BucketName.of("namespace"))
+ .build();
+
+ assertThat(resolver.unresolve(BucketName.of("bucketName")))
+ .contains(BucketName.of("bucketName"));
+ }
+
+ @Test
+ void unresolveShouldReturnValueWhenNamespace() {
Review comment:
Isn't that test doing the same as one of the values in the parameterized
test above `withShouldAddNewValuesInSet`?
##########
File path:
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/BucketNameResolverTest.java
##########
@@ -50,10 +65,45 @@ void resolveShouldReturnValueWhenNamespace() {
assertThat(resolver.resolve(BucketName.of("namespace")))
.isEqualTo(BucketName.of("namespace"));
}
+
+ @Test
+ void unresolveShouldReturnPassedValue() {
Review comment:
Isn't that case checked above in the parameterized test
`withShouldAddNewValuesInSet`?
##########
File path:
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/BucketNameResolverTest.java
##########
@@ -50,10 +65,45 @@ void resolveShouldReturnValueWhenNamespace() {
assertThat(resolver.resolve(BucketName.of("namespace")))
.isEqualTo(BucketName.of("namespace"));
}
+
+ @Test
+ void unresolveShouldReturnPassedValue() {
Review comment:
In a more general manner, isn't this the same for tests in other nested
classes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
