chibenwa commented on a change in pull request #546:
URL: https://github.com/apache/james-project/pull/546#discussion_r676290337
##########
File path:
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/BucketNameResolverTest.java
##########
@@ -50,10 +65,45 @@ void resolveShouldReturnValueWhenNamespace() {
assertThat(resolver.resolve(BucketName.of("namespace")))
.isEqualTo(BucketName.of("namespace"));
}
+
+ @Test
+ void unresolveShouldReturnPassedValue() {
Review comment:
> In a more general manner, isn't this the same for tests in other
nested classes?
Yes but un top of different bucket resolver configuration and it (might or
might not) yield different results.
Being very sure of the behaviour of that class is very important to me, I
assume 100% having a very detailed test suite here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
