chibenwa commented on a change in pull request #546:
URL: https://github.com/apache/james-project/pull/546#discussion_r676290450



##########
File path: 
server/blob/blob-s3/src/test/java/org/apache/james/blob/objectstorage/aws/BucketNameResolverTest.java
##########
@@ -50,10 +65,45 @@ void resolveShouldReturnValueWhenNamespace() {
             assertThat(resolver.resolve(BucketName.of("namespace")))
                 .isEqualTo(BucketName.of("namespace"));
         }
+
+        @Test
+        void unresolveShouldReturnPassedValue() {

Review comment:
       The parametrized test ensure that we can revert the resolution:
   
   ```
   Whatever (x)
   unesolve(resolve(x)) = x
   
   Mathematically: f-1(f(x)) = x
   ```
   
   This is very different from testing the behaviour of `f-1` alias `unresolve` 
alone.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to