vttranlina commented on code in PR #1471:
URL: https://github.com/apache/james-project/pull/1471#discussion_r1122843606
##########
server/protocols/webadmin/webadmin-jmap/src/main/java/org/apache/james/webadmin/data/jmap/dto/UserIdentity.java:
##########
@@ -113,6 +131,43 @@ public UserIdentity(String name, String email, String id,
this.replyTo = replyTo;
}
+ @JsonCreator
+ public UserIdentity(@JsonProperty("name") String name,
Review Comment:
> why there is no mayDelete field
The current API does not accept input `mayDelete` field
Quote:
```
org.apache.james.jmap.api.identity.IdentityRepository#save
mayDelete alway is TRUE
```
Should we modify it for web-admin case?
> I would see more this as a UserIdentityCreate or something similar
Yes, it will be clear if we have a separate object `UserIdentityCreate` /
`UserIdentiteUpdate`,
But, IMO, it is simple pojo, we can re-use it in a single object
`UserIdentity`, less boilerplate.
So, I didn't create UserIdentityCreate...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
