Arsnael commented on code in PR #1471:
URL: https://github.com/apache/james-project/pull/1471#discussion_r1122900563
##########
server/protocols/webadmin/webadmin-jmap/src/main/java/org/apache/james/webadmin/data/jmap/dto/UserIdentity.java:
##########
@@ -113,6 +131,43 @@ public UserIdentity(String name, String email, String id,
this.replyTo = replyTo;
}
+ @JsonCreator
+ public UserIdentity(@JsonProperty("name") String name,
Review Comment:
Forget the mayDelete field remark, as said in latest comment it's indeed
server-set.
> Yes, it will be clear if we have a separate object UserIdentityCreate /
UserIdentiteUpdate,
> But, IMO, it is simple pojo, we can re-use it in a single object
UserIdentity, less boilerplate.
Honestly it was a bit confusing to me, I had to re-read it to understand
what it was for^^'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
