Arsnael commented on code in PR #1471:
URL: https://github.com/apache/james-project/pull/1471#discussion_r1122898278
##########
server/protocols/webadmin/webadmin-jmap/src/test/java/org/apache/james/webadmin/data/jmap/UserIdentitiesRoutesTest.java:
##########
@@ -290,4 +292,219 @@ void
listIdentitiesShouldReturnNotFoundWhenCanNotQueryDefaultIdentity() {
" \"details\": null" +
"}");
}
+
+ @Test
+ void createIdentityShouldWork() {
+ String creationRequest = "" +
+ " {" +
+ " \"name\": \"create name 1\"," +
+ " \"email\": \"[email protected]\"," +
+ " \"mayDelete\": true," +
Review Comment:
Actually good point, in the spec it is supposed to be server-set only indeed.
Just remove this in the test, and maybe make sure with an other test that if
a request comes with mayDelete to false (and even true?), we should reject it,
as for server-set values, in the spec, it says the client MUST NOT send this
property when creating a new object of this type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
