Arsnael commented on code in PR #1648:
URL: https://github.com/apache/james-project/pull/1648#discussion_r1296940048
##########
backends-common/opensearch/pom.xml:
##########
@@ -71,6 +71,18 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-configuration2</artifactId>
</dependency>
+ <!-- Needed for opensearch-java dependency -->
+ <dependency>
+ <groupId>org.apache.httpcomponents.client5</groupId>
+ <artifactId>httpclient5</artifactId>
+ <version>5.1.4</version>
+ </dependency>
+ <!-- Needed for opensearch-java dependency -->
+ <dependency>
+ <groupId>org.apache.httpcomponents.core5</groupId>
+ <artifactId>httpcore5</artifactId>
+ <version>5.1.5</version>
+ </dependency>
Review Comment:
I forgot where I found that last time but I remember the scope of those deps
in opensearch-java client was runtime, as you can see here:
[deps.txt](https://github.com/apache/james-project/files/12367658/deps.txt)
Agreed that httpclient5 brings along httpcore5 though, unecessary indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
