chibenwa commented on code in PR #1648:
URL: https://github.com/apache/james-project/pull/1648#discussion_r1296976932


##########
backends-common/opensearch/pom.xml:
##########
@@ -71,6 +71,18 @@
             <groupId>org.apache.commons</groupId>
             <artifactId>commons-configuration2</artifactId>
         </dependency>
+        <!-- Needed for opensearch-java dependency -->
+        <dependency>
+            <groupId>org.apache.httpcomponents.client5</groupId>
+            <artifactId>httpclient5</artifactId>
+            <version>5.1.4</version>
+        </dependency>
+        <!-- Needed for opensearch-java dependency -->
+        <dependency>
+            <groupId>org.apache.httpcomponents.core5</groupId>
+            <artifactId>httpcore5</artifactId>
+            <version>5.1.5</version>
+        </dependency>

Review Comment:
   Conflicts:
   
   ```
   [INFO] |  +- org.opensearch.client:opensearch-rest-client:jar:2.7.0:runtime
   [INFO] |  |  +- (org.apache.httpcomponents:httpclient:jar:4.5.14:runtime - 
version managed from 4.5.13; omitted for duplicate)
   ```
   
   Likey an issue... The offender is restassured. Please force this dependency, 
no need to specify the version as we manage it in the root POM.
   
   Idem forcethe version of httpcore to 4.4.16...
   
   The conflict likely occurs because of restassured thus that would be why the 
leakwould only happen in tests.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to