Arsnael commented on code in PR #1648:
URL: https://github.com/apache/james-project/pull/1648#discussion_r1297026026
##########
backends-common/opensearch/pom.xml:
##########
@@ -71,6 +71,18 @@
<groupId>org.apache.commons</groupId>
<artifactId>commons-configuration2</artifactId>
</dependency>
+ <!-- Needed for opensearch-java dependency -->
+ <dependency>
+ <groupId>org.apache.httpcomponents.client5</groupId>
+ <artifactId>httpclient5</artifactId>
+ <version>5.1.4</version>
+ </dependency>
+ <!-- Needed for opensearch-java dependency -->
+ <dependency>
+ <groupId>org.apache.httpcomponents.core5</groupId>
+ <artifactId>httpcore5</artifactId>
+ <version>5.1.5</version>
+ </dependency>
Review Comment:
Not sure to get it..? httpclient5 and httpcore5 are different libs from
httpcore and httpclient? They even have different group ids. I don't see the
correlation here
Reminder that the leak blew up in my face big time during perf tests on
sandbox, so not only happening in our test suite
Or did i miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
