quantranhong1999 commented on code in PR #1651:
URL: https://github.com/apache/james-project/pull/1651#discussion_r1303735950


##########
server/apps/distributed-app/docker-compose-with-pulsar.yml:
##########
@@ -34,10 +21,11 @@ services:
       - "8000:8000"
     volumes:
       - ./sample-configuration/pulsar.properties:/root/conf/pulsar.properties
-      - ./sample-configuration/keystore:/root/conf/keystore
+      - ./sample-configuration/queue.properties:/root/conf/queue.properties

Review Comment:
   That is not the rationale. 
   The above error is just the surface of the ice IMO.
   We did not need the @Inject before, and which change forced us to change 
that? Can you investigate more to see if we can fix it another way?
   
   FYI, before we already declared a bean (on top of a method) for 
`ReactorRabbitMQChannelPool`: 
https://github.com/apache/james-project/blob/master/server/container/guice/queue/rabbitmq/src/main/java/org/apache/james/modules/queue/rabbitmq/RabbitMQModule.java#L134.
 That is why we do not need to declare a bean using @Inject (on top of the 
constructor).
   
   I would suspect the James with Pulsar server is missing that bean (on top of 
a method) module...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to