felixauringer commented on PR #2773: URL: https://github.com/apache/james-project/pull/2773#issuecomment-3384541538
The MPT tests are working again now. The two logout tests which I added are still failing. As described [above](https://github.com/apache/james-project/pull/2773#issuecomment-3191333089), I would like to keep those tests but do not know how to fix them. There is also one test which I marked as disabled. It checks for malformed authentication data and currently fails but would also have failed with the original implementation. The current code is definitive too lenient when looking at the RFC but I didn't know whether there was a specific reason to allow this case (You also allow spaces as separators in the authentication data instead of null bytes. This is also not correct, but I left it as is and didn't write a test for it.) Are there any clients that rely on these non-RFC-compliant behaviors? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
