felixauringer commented on code in PR #2773: URL: https://github.com/apache/james-project/pull/2773#discussion_r2510071307
########## mpt/impl/managesieve/core/src/main/resources/org/apache/james/managesieve/scripts/capability.test: ########## @@ -38,8 +38,9 @@ S: "VERSION" "1.0" S: OK C: AUTHENTICATE "PLAIN" -S: \+ "" -C: user password +S: "" +S: OK +C: "user password" Review Comment: Yes, I am pretty sure that having spaces as separator is not compliant. If that's okay for you, I am fine with removing them. The [RFC](https://datatracker.ietf.org/doc/html/rfc4616) actually also does not mention base64 but I also have never seen it without it. The current behavior implementation allows the following for `PLAIN`: - null as delimiter, then base64 encoded, then quoted - null as delimiter, then quoted - space as delimiter, then quoted (strings always need to be quoted except if the length is given beforehand) Which of those behaviors would you like to be supported? I implemented all of them because the other protocols allow these options. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
