chibenwa commented on code in PR #2773:
URL: https://github.com/apache/james-project/pull/2773#discussion_r2519729794


##########
protocols/managesieve/src/main/java/org/apache/james/managesieve/core/PlainAuthenticationProcessor.java:
##########
@@ -50,7 +50,7 @@ public PlainAuthenticationProcessor(UsersRepository 
usersRepository) {
 
     @Override
     public String initialServerResponse(Session session) {
-        return "+ \"\"";
+        return "\"\"\r\nOK";

Review Comment:
   Hello @felixauringer 
   
   Thanks for having a look
   
   I think as an implementer I just sticked to RFC-4616 exemples, yes (but 
that's10 years back.... I'm a bit rusty on the topic)
   
   Note that the `""` is likely none compulsory and not returned eg by the IMAP 
layer which also implement RFC-4616...
   
   While what comes after is subject to discussion the fact of doing a 
continuation is mandatory.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to