Arsnael commented on PR #3193: URL: https://github.com/apache/james-project/pull/3193#issuecomment-5770834251
hello, The structure looks better yes thank you @HesandaLiyanage https://ci-builds.apache.org/job/james/job/ApacheJames/job/PR-3193/2/ New test failures still related to this work. It seems some guice bindings are missing: 1) [Guice/MissingImplementation]: No implementation for BlobIdUpdater was bound. Requested by: 1 : BlobCompactionModule.blobCompactionAlgorithm(BlobCompactionModule.java:63) \_ for 4th parameter blobIdUpdater at BlobCompactionModule.blobCompactionAlgorithm(BlobCompactionModule.java:63) \_ installed by: Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$CombinedModule -> Modules$CombinedModule -> Modules$CombinedModule -> BlobCompactionModule Learn more: https://github.com/google/guice/wiki/MISSING_IMPLEMENTATION 2) [Guice/MissingImplementation]: No implementation for BlobReferenceMappingSource was bound. Requested by: 1 : BlobCompactionModule.blobCompactionAlgorithm(BlobCompactionModule.java:63) \_ for 3rd parameter mappingSource at BlobCompactionModule.blobCompactionAlgorithm(BlobCompactionModule.java:63) \_ installed by: Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$OverrideModule -> Modules$CombinedModule -> Modules$CombinedModule -> Modules$CombinedModule -> BlobCompactionModule Learn more: https://github.com/google/guice/wiki/MISSING_IMPLEMENTATION 2 errors -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
