HesandaLiyanage commented on PR #3193: URL: https://github.com/apache/james-project/pull/3193#issuecomment-5777120881
> Thanks for all the fixes. > > That's a major changeset. I really woupd support (out of the CI) **Property Based Testing** for this so that we can develop confidence on it. ( https://www.scalatest.org/user_guide/property_based_testing for instance ) it should be able to generate large set of object within a generation, perform compact and delete in random manner under various profiles (delete heavy or not - configurable and tested accross a wide range of value, possibly randomly set between each compacts) and ensure along several runs that 1- count of object decrease in a predicable fashion and 2- no dead references are created. > > The review is massive, and I do not want to delegate this to an AI, I'll try to cover a review of this by the end of the week. > > Cheers, > > Benoit Thanks so much, really appreciate you taking the time on this. Yeah let's do the property based testing. that's way better than me just eyeballing it after a few manual runs. i'll start working around with that on my side in the meantime. looking forward to your feedback by end of week, no rush though given how big this changeset is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
