> * @see
> org.jclouds.googlecomputeengine.features.FirewallApi#patch(String,
> org.jclouds.googlecomputeengine.options.FirewallOptions)
> */
> - private void getOrCreateFirewalls(GoogleComputeEngineTemplateOptions
> templateOptions, Network network,
> - FirewallTagNamingConvention naming) {
> -
> + private void
> getAndUpdateOrCreateFirewalls(GoogleComputeEngineTemplateOptions
> templateOptions, Network network,
> + String sharedResourceName) {
> + String firewallName =
> templateOptions.getNetworkName().or(sharedResourceName);
So if I understand correctly, we're removing the `FirewallTagNamingConvention`
and replacing this with `templateOptions.getNetworkName()`, falling back to the
group name if that is empty. That's not a backwards-compatible change, if I
understand that correctly?
@abayer: Thoughts?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r11358585
