> - network.getSelfLink(),
> - firewallOptions));
> - operations.add(operation);
> - }
> - }
> -
> - for (AtomicReference<Operation> operation : operations) {
> + Firewall firewall = firewallApi.get(firewallName);
> + Set<Rule> rules =
> createFirewallRulesFromInboundPorts(templateOptions.getInboundPorts());
> + FirewallOptions firewallOptions = new
> FirewallOptions().name(firewallName).network(network.getSelfLink())
> +
> .sourceTags(templateOptions.getTags())
> +
> .sourceRanges(of(DEFAULT_INTERNAL_NETWORK_RANGE,
> +
> EXTERIOR_RANGE));
> + if (firewall == null) {
> + firewallOptions.allowedRules(rules);
> + AtomicReference<Operation> operation =
> newReference(firewallApi.createInNetwork(firewallOptions.getName(),
[minor] Formatting: move `newReference` down onto the next line and then put
all the arguments on _one_line?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r11358713
