>           retry(operationDonePredicate, operationCompleteCheckTimeout, 
> operationCompleteCheckInterval,
>                   MILLISECONDS).apply(operation);
> -         checkState(!operation.get().getHttpError().isPresent(),"Could not 
> create firewall, operation failed" + operation);
> +         checkState(!operation.get().getHttpError().isPresent(), "Could not 
> patch firewall, operation failed " + operation);
> +      }
> +   }
> +
> +   private Set<Rule> createFirewallRulesFromInboundPorts(int[] inboundPorts) 
> {
> +      Set<Rule> rules = Sets.newLinkedHashSet();

Guess we need a sorted set here? Or why a LinkedHashSet?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/20/files#r11358786

Reply via email to