> @@ -103,9 +102,12 @@ public Statement apply(String group) {
>  
>        String chefConfigDir = "{root}etc{fs}chef";
>        Statement createChefConfigDir = exec("{md} " + chefConfigDir);
> +      String createNodeName = String.format("node_name \"%s-\" + 
> o[:ipaddress]", group);
> +      if (nodeName != null) {
> +        createNodeName = String.format("node_name \"%s\"", nodeName);
> +      }

Can you change it to avoid creating a String object that you will potentially 
reassign immediately after? Just assign the right value directly with an 
if/else clause.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/622/files#r21267422

Reply via email to