> @@ -171,8 +172,8 @@ String buildBootstrapConfiguration(BootstrapConfig
> bootstrapConfig) {
> }
>
> @Override
> - public Statement createBootstrapScriptForGroup(String group) {
> - return groupToBootScript.apply(group);
> + public Statement createBootstrapScriptForGroup(String group, @Nullable
> String nodeName) {
> + return groupToBootScript.apply(group, null);
Ok, cool and committed. So just to be clear we’re fine with changing the method
signature vs adding a second method that would support older implementations
that are passing only one input parameter i.e. group?
> On Dec 4, 2014, at 7:57 AM, Ignasi Barrera <[email protected]> wrote:
>
> In apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java:
>
> > @@ -171,8 +172,8 @@ String buildBootstrapConfiguration(BootstrapConfig
> > bootstrapConfig) {
> > }
> >
> > @Override
> > - public Statement createBootstrapScriptForGroup(String group) {
> > - return groupToBootScript.apply(group);
> > + public Statement createBootstrapScriptForGroup(String group, @Nullable
> > String nodeName) {
> > + return groupToBootScript.apply(group, null);
> Absolutely. I thought there were the two methods in some previous commit...
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/jclouds/jclouds/pull/622/files#r21313028>.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/622/files#r21320153