> @@ -171,8 +172,8 @@ String buildBootstrapConfiguration(BootstrapConfig
> bootstrapConfig) {
> }
>
> @Override
> - public Statement createBootstrapScriptForGroup(String group) {
> - return groupToBootScript.apply(group);
> + public Statement createBootstrapScriptForGroup(String group, @Nullable
> String nodeName) {
> + return groupToBootScript.apply(group, null);
Shouldn't the second parameter be nodeName and not null? I was thinking about
this more. Shouldn't the ChefService interface have 2 methods? One that accepts
one parameter, group and another that accepts two parameters, group and node
name? Otherwise the signature change would force others to change their code?
Thanks,
Will
> On Dec 4, 2014, at 02:36, Ignasi Barrera <[email protected]> wrote:
>
> In apis/chef/src/main/java/org/jclouds/chef/internal/BaseChefService.java:
>
> > @@ -171,8 +172,8 @@ String buildBootstrapConfiguration(BootstrapConfig
> > bootstrapConfig) {
> > }
> >
> > @Override
> > - public Statement createBootstrapScriptForGroup(String group) {
> > - return groupToBootScript.apply(group);
> > + public Statement createBootstrapScriptForGroup(String group, @Nullable
> > String nodeName) {
> > + return groupToBootScript.apply(group, null);
> Hmmm this is wrong now? There should be two methods, one passing null and the
> other one passing the nodeName.
>
> —
> Reply to this email directly or view it on GitHub.
>
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/622/files#r21312577
