@ritazh What is your preferred procedure for suggesting changes to the Azure 
ARM provider? I understand that it's still heavily work in progress, but I 
wanted to try it and provide feedback. And I thought that a PR would be the 
best feedback :-)

Other than these 2 changes, my only objection is that listing all images is 
painfully slow, because it has to perform O(numLocations * numPublishers * 
numOffers * numSkus * numVersions) API requests. Even with the default 
configuration of `"Canonical,RedHat"`, it still takes like 5 minutes for me. I 
wouldn't mind if listing all images wasn't performed during node creation. 
(It's also the motivation for one of the commits that replaces a call to 
`listImages` inside `getImage` with a single direct API request, but sadly, 
that doesn't fix everything.)
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds-labs/pull/298

-- Commit Summary --

  * [JCLOUDS-664] make getImage(id) only do a single API request
  * [JCLOUDS-664] fill in the private IP addresses in NodeMetadata

-- File Changes --

    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/AzureComputeServiceAdapter.java
 (17)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/compute/functions/DeploymentToNodeMetadata.java
 (14)
    M 
azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/VMDeployment.java
 (2)

-- Patch Links --

https://github.com/jclouds/jclouds-labs/pull/298.patch
https://github.com/jclouds/jclouds-labs/pull/298.diff

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/298

Reply via email to