>And in another commit, I converted VMDeployment to use AutoValue. I'm not 100% >sure about @SerializedNames, but other than that, I think it should be OK. >TBH, VMDeployment is just an internal DTO class that isn't returned by any >Azure API nor is it a part of this provider's API, so I think it could have >easily stayed as it was, but whatever :-)
We want to unify the way we code our POJOs and domain objects and use AutoValue as it provides out of the box some features we were manually enforcing: immutability, consistent implementations of equals/hashcode, clean builders, etc. It is not meant just to be used to map the provider API model, but the way we want to go to have a proper immutable model. Even when coding internal POJOs, we should try to use it. You are right regarding the `@SerializedNames` annotation; it is not needed in these classes as they're not going to be (de)serialized, so feel free to remove them if you want. That would be good, as having them there could cause some confusion. Anyway, code LGTM :) Thanks! Will merge in a while. --- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/jclouds/jclouds-labs/pull/298#issuecomment-232795199
