nacx commented on this pull request.
> + }
+
+ List<Processor> processors = new ArrayList<Processor>();
+ for (int i = 0; i < server.hardware().vcore(); i++) {
+ Processor proc = new
Processor(server.hardware().coresPerProcessor(), 1d);
+ processors.add(proc);
+ }
+ AutomaticHardwareIdSpec id =
AutomaticHardwareIdSpec.automaticHardwareIdSpecBuilder(server.hardware().vcore(),
(int) minRam, Optional.of((float) size));
+ hardware = new HardwareBuilder()
+ .ids(id.toString())
+ .ram((int) minRam)
+ .processors(ImmutableList.copyOf(processors))
+ .hypervisor("kvm")
+ .volumes(volumes)
+ .location(location)
+ .build();
I don't think so. That is there because Google has its own way of deploying
custom hardware profiles, encoding the values in the "size uri".
Let's leave this as-is in this PR. It's not a critical thing to change.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338#discussion_r101575984
