nacx requested changes on this pull request.
This looks much cleaner now! :)
I've added the final comments, but this looks great. Thanks!
> import org.jclouds.util.InetAddresses2;
public class ServerToNodeMetadata implements Function<Server, NodeMetadata> {
private final Supplier<Set<? extends Location>> locations;
+ private final Supplier<Map<String, ? extends Hardware>> hardwareFalvors;
typo: `Falvors`
> +
+ public abstract Builder osImageType(Types.OSImageType osImageType);
+
+ public abstract Builder minHddSize(int minHddSize);
+
+ public abstract Builder type(Types.ApplianceType type);
+
+ public abstract Builder state(String state);
+
+ public abstract Builder version(String version);
+
+ public abstract Builder categories(List<String> categories);
+
+ public abstract Builder eulaUrl(String eulaUrl);
+
+ public abstract SingleServerAppliance build();
Use [this
pattern](https://github.com/jclouds/jclouds-labs/blob/master/azurecompute-arm/src/main/java/org/jclouds/azurecompute/arm/domain/AvailabilitySet.java#L82-L90)
to enforce immutable collections in builders.
> @@ -41,6 +41,6 @@
}
public static long millisUntilNextAvailableRequest(long
secondsToNextAvailableRequest) {
- return secondsToNextAvailableRequest * 1000;
+ return secondsToNextAvailableRequest * 8000;
This should return the seconds until the next available request. The previous
value looked OK, as it configures the exact value returned by the provider in
the response headers.
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/338#pullrequestreview-23183103
