ulysses-you commented on a change in pull request #2193:
URL: https://github.com/apache/incubator-kyuubi/pull/2193#discussion_r832012546
##########
File path:
dev/kyuubi-extension-spark-common/src/main/antlr4/org/apache/kyuubi/sql/zorder/ZorderSqlExtensions.g4
##########
@@ -76,6 +82,11 @@ comparisonOperator
: EQ | NEQ | NEQJ | LT | LTE | GT | GTE | NSEQ
;
+expression
Review comment:
I'm a little confused with this name. I see it comes from iceberg, but
why not name it as `argument` ? The semantics of expression in Spark is
different with this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
