zinking commented on pull request #2193: URL: https://github.com/apache/incubator-kyuubi/pull/2193#issuecomment-1075980778
> The existed antlr4 file is for Z-Order, it should not add other procedures. > > I think we can add a new antlr4 file and something else into tpcds module, so we don't need depend on Spark extension module. it is a bit weird to add new semantics into something called z-order. so the problem is are we expecting adding new syntaxes ? or we are adopting a syntax per file approach (which a lot of code duplication would occur). that would work, but code is expected to duplicate in that case. **and** originally my intention is that this procedure could be reused in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
